feat: add Multikey as supported vm type #1720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
TimoGlastra
approved these changes
Jan 31, 2024
| @@ -40,6 +44,10 @@ export const keyDidEd25519: KeyDidMapping = { | |||
| return getKeyFromJsonWebKey2020(verificationMethod) | |||
| } | |||
|
|
|||
| if (isMultikey(verificationMethod)) { | |||
There was a problem hiding this comment.
We also have this in keyDidMapping (a higher level), so i don't know when it'll reach this, but i see we have the same duplication for JsonWebKey2020 so it's okay for now.
We can refactor it a bit later on
| ) | ||
| } | ||
|
|
||
| return Key.fromFingerprint(verificationMethod.publicKeyMultibase) |
There was a problem hiding this comment.
fingerprint was supposed to give a fingerprint of the key, and it also is a multibase encoding. Might be good to add a toMultibase and fromMultibase options and also support e.g. base64 encoding as described in the di spec. But fine for now
|
Thanks 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
Multikeyverification method type defined in vc-data-integrity. Similar toJsonWebKey2020, it can be used to represent multiple key types.This is perhaps a naive implementation. This is my first time digging around inside of credo. Please let me know if there's anything I need to improve!