feat: optional backup on storage migration #1745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ariel Gentile <gentilester@gmail.com>
Signed-off-by: Ariel Gentile <gentilester@gmail.com>
TimoGlastra
approved these changes
Feb 6, 2024
| @@ -82,7 +82,7 @@ describe('UpdateAssistant | AnonCreds | v0.3.1 - v0.4', () => { | |||
| }, | |||
| ]) | |||
|
|
|||
| await updateAssistant.update('0.4') | |||
| await updateAssistant.update({ updateToVersion: '0.4' }) | |||
There was a problem hiding this comment.
note to self: update in update docs
| @@ -71,6 +71,10 @@ export class AgentConfig { | |||
| return this.initConfig.autoUpdateStorageOnStartup ?? false | |||
| } | |||
|
|
|||
| public get backupBeforeStorageUpdate() { | |||
There was a problem hiding this comment.
One thing to consider though that not creating a backup may be seen as advanced and you should use the update assistant in this case? But if it's useful to add this to the default agent startup, then I'm ok with it 👍
Signed-off-by: Ariel Gentile <gentilester@gmail.com>
Signed-off-by: Ariel Gentile <gentilester@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make storage backup optional during wallet storage migration process. This is mainly to allow storage migration for those wallets that do not support exporting (like Askar wallets using PosgreSQL).
@TimoGlastra I have to review it a bit more and add some tests, but wanted to open it now so you can check if it fits the changes you are doing on your side.