Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cheqd): do not crash agent if cheqd down #1808

Conversation

TimoGlastra
Copy link
Contributor

Adds some error handling to make sure the agent initialization does not fail if a cheqd network is down. As this prevents wallets and servers from starting.

Also updates test to not rely on cheqd testnet, but rather a local network so we're not dependant on external services

Signed-off-by: Timo Glastra <timo@animo.id>
Copy link
Contributor

@berendsliedrecht berendsliedrecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's all that is required?

@TimoGlastra
Copy link
Contributor Author

oh damn forgot to push the important part 🤦

Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
@TimoGlastra TimoGlastra merged commit 842efd4 into openwallet-foundation:main Mar 28, 2024
12 checks passed
@TimoGlastra TimoGlastra deleted the fix/do-not-crash-agent-if-cheqd-down branch March 28, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants