Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: setting runtime attributes at runtime #5855 #401

Closed
pieterlukasse opened this issue Sep 24, 2020 · 6 comments
Closed

Feature request: setting runtime attributes at runtime #5855 #401

pieterlukasse opened this issue Sep 24, 2020 · 6 comments

Comments

@pieterlukasse
Copy link

Hi,

I would like to be able to override something like:

    runtime {
        docker: "mydockerimagename"
    }

at runtime. Is this possible already? I know people have been using workarounds by making the docker image name to be an input variable. I would like to have it separate from workflow input variables though.

@DavyCats
Copy link
Contributor

I believe this is being addressed as part of #315.

@jdidion
Copy link
Collaborator

jdidion commented Sep 24, 2020

I believe this is something that would have to be implemented by the runtime engine.

@pieterlukasse what specifically would you add to/change in the spec?

@jdidion
Copy link
Collaborator

jdidion commented Sep 24, 2020

I guess one possibility is that since runtime is a reserved word, the attributes could be overridden in the input file

"<task>.runtime.container": "ubuntu"

@jdidion
Copy link
Collaborator

jdidion commented Sep 24, 2020

Ah, and now I see that's exactly what #315 specifies😁

@pieterlukasse
Copy link
Author

Yes, thanks! More specifically here https://github.com/openwdl/wdl/pull/315/files#diff-7ab1be25d3b4d9ecf4f763e14d464681R3029

This is great news. What are the plans for implementing this? I guess that is again a question for the Cromwell team...

@patmagee
Copy link
Member

patmagee commented Oct 1, 2020

@pieterlukasse as always, it will be up to the engines. If you have the scala chops you could always submit a PR to help them get there faster, (or miniwdl or dxwdl for that).

@patmagee patmagee closed this as completed Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants