Skip to content
This repository has been archived by the owner on Dec 20, 2023. It is now read-only.

STD_DEFINES should not include BOARD_PCA10056 #245

Closed
jaylogue opened this issue May 29, 2019 · 1 comment
Closed

STD_DEFINES should not include BOARD_PCA10056 #245

jaylogue opened this issue May 29, 2019 · 1 comment
Assignees
@jaylogue

Comments

@jaylogue
Copy link
Contributor

In nrf5-app.mk, STD_DEFINES should not include SoC and board-specific defines, such as NRF52840_XXAA or BOARD_PCA10056. Rather, these should be set by the project Makefile in its DEFINES variable.
@jaylogue jaylogue self-assigned this May 29, 2019
@jaylogue jaylogue mentioned this issue May 29, 2019
Open
@jaylogue
Copy link
Contributor Author

jaylogue commented Jun 4, 2019

Fixed in commit 8952f08.

@jaylogue jaylogue closed this as completed Jun 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jaylogue jaylogue

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jaylogue