Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui:bug] Notification Toast Container Disappears #264

Open
Aryamanz29 opened this issue Jul 27, 2023 · 1 comment
Open

[ui:bug] Notification Toast Container Disappears #264

Aryamanz29 opened this issue Jul 27, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@Aryamanz29
Copy link
Member

I encountered a bug while implementing background API tasks for the ZeroTier VPN backend in openwisp-controller.

When a background API task encounters an unrecoverable failure or recovers from any API failures, it generates an error or recovery type notification, respectively. However, if this notification is generated right after saving or updating the VPN object, the notification toast gets automatically dismissed due to the already-present Django model object's success message.

api_task_notification_bug

I tried to address this issue by adding some delay to the notification, but this solution may not be optimal. We need to find a better and more reliable solution to prevent the notification toast from disappearing prematurely.

@pandafy
Copy link
Member

pandafy commented Jul 31, 2023

@Aryamanz29 you misinterpreted the bug here.

When the user clicks on the "Save and Continue" or "Save" button, the webpage reloads. This closes the websocket connection. The websocket connection is established again after the page loads.

The notification toast is only shown when a notification is received through the websocket connection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants