Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] FilterSerializerByOrganization filters fields without organization #319

Open
pandafy opened this issue Jun 17, 2022 · 2 comments
Open
Labels

Comments

@pandafy
Copy link
Member

pandafy commented Jun 17, 2022

FilterSerializerByOrganization filters queryset of all related fields using the organization_lookup. But, it might be possible that a model does not have relation to Organization (not even an indirect one, e.g. WiFiClient in openwisp-monitoring).

We should allow to exclude fields from the organization filtering.

@nemesifier
Copy link
Member

@Aryamanz29 do you think this was fixed by 670ec93 ?

@Aryamanz29
Copy link
Member

Aryamanz29 commented Oct 28, 2023

@Aryamanz29 do you think this was fixed by 670ec93 ?

@nemesifier I don't think this issue has been addressed, and I believe it remained unresolved during the development of multitenant capabilities for the Django Filters feature. This happened because we decided to complete that PR only for the Wi-Fi session REST API. Previously, we were also working on adding a REST API for Wi-Fi clients, and it was during that time that we encountered this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants