Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace remote connections in test_http_stacktrace or skip locally #891

Open
boolean5 opened this issue Apr 16, 2021 · 1 comment
Open
Labels
task Doesn't change any behaviour

Comments

@boolean5
Copy link
Contributor

We've noticed that test_http_stacktrace is flaky when running on CI (see here for a failure example).

This is probably because this test is still making a remote connection to https://gist.githack.com/gunesacar/b927d3fe69f3e7bf456da5192f74beea/raw/8d3e490b5988c633101ec45ef1443e61b1fd495e/inject_pixel.js

We could investigate whether we can replace remote connections in this test with local ones. If not, we should be skipping it locally as we do for test_browser_profile_coverage and test_name_resolution.

@boolean5 boolean5 added the task Doesn't change any behaviour label Apr 16, 2021
@vringar
Copy link
Contributor

vringar commented Apr 17, 2021

Maybe we can remove the remote connection by using the pref englehardt mentioned in #197

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Doesn't change any behaviour
Projects
None yet
Development

No branches or pull requests

2 participants