Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luci-app-ksmbd: Using Allowed Users and Enable Allowed Guest, Guest has Write Access #7244

Open
ghost opened this issue Aug 17, 2024 · 1 comment

Comments

@ghost
Copy link

ghost commented Aug 17, 2024

Steps to reproduce:

  1. go to: Services → Network Shares
  2. Add a new share direct
  3. input Allowed Users and checked Allowed Guest
  4. Save & Apply
  5. Use SMB Client with guest access network share

Actual behavior:

Both logged in users and anonymous users have read and write permissions

Expected behavior:

Only logged in users have read and write permissions, anonymous users only have read permissions

Additional Information:

  1. Enable Force Root, Allowed User will not be used. See /etc/init.d/ksmbd
  2. Set read_only to 1 , write_list to 'Allowed Users' (valid users) to resolve.
@ghost
Copy link
Author

ghost commented Aug 17, 2024

Proposal:

  1. When there is only Enable Allowed Guest, the Guest has read and write permission
  2. If read-only is enabled, write list is not set

or

  1. When there is only Enable Allowed Guest, the Guest has read and write permission. (Code not needs to change)
  2. When there is only Using Allowed Users, the User has read and write permission. (Code not needs to change)
  3. Both of them. By setting read_only to 1 and write list to same 'valid users' (if not read-only)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants