Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sstp-client: does not obey the interface metric #25213

Open
patrakov opened this issue Oct 27, 2024 · 0 comments
Open

sstp-client: does not obey the interface metric #25213

patrakov opened this issue Oct 27, 2024 · 0 comments

Comments

@patrakov
Copy link
Contributor

patrakov commented Oct 27, 2024

Maintainer: @vgaetera @fededim
Environment: Any, for example, TP-Link Archer C7 v2 on OpenWrt 23.05.5

Description:

The sstp.sh protocol handler implements all option parsing from scratch instead of inheriting all common PPP option logic. This, for example, leads to the configured interface metric being ignored.

Example of an affected configuration:

config interface 'vpn'
	option proto 'sstp'
	option server 'sstp.vpn.example'
	option username 'username'
	option password 'password'
	option ipv6 '1'
	option log_level '0'
	option peerdns '0'
	list dns '8.8.8.8'
	list dns '8.8.4.4'
	option metric '91'

This results in the created route having no explicit metric, as opposed to metric 91.

A workaround exists, but this should not be necessary:

	option pppd_options 'defaultroute-metric 91'

Please look at how pppossh includes standard functions from ppp.sh and implements its protocol handler on top of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant