feat: upgrade nodepool crd to v1beta2 #2266
Conversation
tnsimon
force-pushed
the
add-nodepool-v1beta2
branch
from
4f8c2ca to
39c82bc
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2266 +/- ##
=======================================
Coverage 45.18% 45.19%
=======================================
Files 422 427 +5
Lines 28779 28868 +89
=======================================
+ Hits 13005 13046 +41
- Misses 14460 14507 +47
- Partials 1314 1315 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| type: object | ||
| type: object | ||
| served: true | ||
| storage: true |
There was a problem hiding this comment.
Yes, I will configure v1beta2 as storage for NodePool, so we need to modify v1beta1 storage to false.
| */ | ||
|
|
||
| // Hub marks this type as a conversion hub. | ||
| func (*NodePool) Hub() {} |
There was a problem hiding this comment.
We need improve v1beta1.NodePool conversion, because v1beta2.NodePool will be used as storage. this means that v1beta1.NodePool should implement ConvertTo and ConvertFrom function for converting between v1beta1 and v1beta2.
| ) | ||
|
|
||
| // SetupWebhookWithManager sets up Cluster webhooks. mutate path, validatepath, error | ||
| func (webhook *NodePoolHandler) SetupWebhookWithManager(mgr ctrl.Manager) (string, string, error) { |
There was a problem hiding this comment.
we can remove webhook of nodepool/v1beta1, and keep nodepool/v1beta2 webhook only.
tnsimon
force-pushed
the
add-nodepool-v1beta2
branch
from
a01256d to
5df865a
Compare
|
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #2258
Special notes for your reviewer:
/assign @rambohe-ch
Does this PR introduce a user-facing change?
other Note