Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] redundant code #486

Closed
adamzhoul opened this issue Sep 22, 2021 · 2 comments · Fixed by #490
Closed

[BUG] redundant code #486

adamzhoul opened this issue Sep 22, 2021 · 2 comments · Fixed by #490
Labels
kind/bug kind/bug

Comments

@adamzhoul
Copy link
Member

openyurt/pkg/yurtctl/cmd/convert/edgenode.go

Line 275 in 797c43d

_, err = kubeutil.AnnotateNode(c.clientSet, node, constants.AnnotationAutonomy, "true")

openyurt/pkg/yurtctl/cmd/convert/edgenode.go

Line 282 in 797c43d

_, err = kubeutil.AnnotateNode(c.clientSet, node, constants.AnnotationAutonomy, "true")

image
@adamzhoul adamzhoul added the kind/bug kind/bug label Sep 22, 2021
@rambohe-ch
Copy link
Member

@adamzhoul Thank you for raising issue.
At present, both yurtctl convert and yurtctl revert are recommended to use for experiencing OpenYurt. and would you be able to add a pull request to fix this duplicated code?

@adamzhoul
Copy link
Member Author

sure

@adamzhoul adamzhoul mentioned this issue Sep 22, 2021
Merged
@adamzhoul adamzhoul mentioned this issue Nov 5, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rm duplicated code adamzhoul/openyurt
2 participants
@adamzhoul @rambohe-ch