Skip to content
This repository has been archived by the owner on Nov 2, 2023. It is now read-only.

NodePool Spec Labels is gone #131

Open
AndyEWang opened this issue Dec 15, 2022 · 1 comment
Open

NodePool Spec Labels is gone #131

AndyEWang opened this issue Dec 15, 2022 · 1 comment
Labels
kind/bug kind/bug

Comments

@AndyEWang
Copy link

What happened:
To add labels in NodePool Spec in api version v1beta1 but nothing is set.

What you expected to happen:
spec.labels is expected in NodePool.

How to reproduce it (as minimally and precisely as possible):

  1. deploy yurt-app-manager v0.6.0
  2. create a nodepool with spec.labels in api version v1beta1
  3. kubectl get nodepool -o yaml

Anything else we need to know?:
suspect that pkg/yurtappmanager/apis/apps/v1beta1/nodepool_conversion.go leads to this. No labels field is converted between v1alpha1 and v1beta1.

	dst.Spec.Selector = src.Spec.Selector
	dst.Spec.Annotations = src.Spec.Annotations
	dst.Spec.Taints = src.Spec.Taints

Environment:

  • OpenYurt version: yurt-app-manager v0.6.0
  • Kubernetes version (use kubectl version): 1.22

others

/kind bug

@AndyEWang AndyEWang added the kind/bug kind/bug label Dec 15, 2022
@rambohe-ch
Copy link
Member

@kadisi PTAL

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug kind/bug
Projects
None yet
Development

No branches or pull requests

2 participants