Skip to content
This repository has been archived by the owner on Nov 2, 2023. It is now read-only.

【feature request】YurtAppSet and YurtAppDaemon should support rollback #135

Open
SQxiaoxiaomeng opened this issue Jan 13, 2023 · 4 comments
Labels
kind/feature kind/feature

Comments

@SQxiaoxiaomeng
Copy link

What would you like to be added:
YurtAppSet and YurtAppDaemon should support rollback like Deployment

Why is this needed:

others
/kind feature

@SQxiaoxiaomeng SQxiaoxiaomeng added the kind/feature kind/feature label Jan 13, 2023
@rambohe-ch
Copy link
Member

@SQxiaoxiaomeng Thank you for raising issue.
I think YurtAppSet can support rollback now. and you can update the specified nodePool template, then the underlying Deployment will rollback the pods in this NodePool.

@rambohe-ch
Copy link
Member

@SQxiaoxiaomeng BTW, YurtAppDaemon looks like that can not support rollback strategy now.

@SQxiaoxiaomeng
Copy link
Author

SQxiaoxiaomeng commented Jan 14, 2023

@rambohe-ch I'm sorry I didn't express clearly. What I want to say is that YurtAppSet should support rolling back to a certain historical version, just like kubectl rollout history deployment/xxx --revison=2,not to modify yaml.

@rambohe-ch
Copy link
Member

rambohe-ch commented Jan 14, 2023

@rambohe-ch I'm sorry I didn't express clearly. What I want to say is that YurtAppSet should support rolling back to a certain historical version, just like kubectl rollout history deployment/xxx --revison=2,not to modify yaml.

@SQxiaoxiaomeng Thank you for your kindly response. I think this feature requirement is quite reasonable. @kadisi Do you have any comments?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature kind/feature
Projects
None yet
Development

No branches or pull requests

2 participants