yurt ingress use helm reconcile #124
Conversation
|
@huiwq1990: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: huiwq1990 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -64,6 +65,7 @@ func (o *YurtAppOptions) AddFlags(fs *pflag.FlagSet) { | |||
| fs.BoolVar(&o.EnablePprof, "enable-pprof", o.EnablePprof, "Enable pprof for controller manager.") | |||
| fs.StringVar(&o.LeaderElectionNamespace, "leader-election-namespace", o.LeaderElectionNamespace, "This determines the namespace in which the leader election configmap will be created, it will use in-cluster namespace if empty.") | |||
| fs.StringVar(&o.Namespace, "namespace", o.Namespace, "Namespace if specified restricts the manager's cache to watch objects in the desired namespace. Defaults to all namespaces.") | |||
| fs.StringVar(&o.WorkloadNamespace, "workloadNamespace", o.WorkloadNamespace, "") | |||
There was a problem hiding this comment.
please add description for the parameter.
|
|
||
| // Indicates all the nodepools on which to enable ingress. | ||
| // +optional | ||
| Conditions YurtIngressCondition `json:"conditions,omitempty"` |
There was a problem hiding this comment.
Conditions YurtIngressCondition --> Conditions []YurtIngressCondition?
|
@zzguang PTAL |
huiwq1990
force-pushed
the
feat-helminstall
branch
from
64934c1 to
0416684
Compare
huiwq1990
force-pushed
the
feat-helminstall
branch
from
0416684 to
e7fe1c2
Compare
huiwq1990
force-pushed
the
feat-helminstall
branch
from
e7fe1c2 to
19accd9
Compare
Signed-off-by: huiwq1990 <huiwq1990@163.com>
huiwq1990
force-pushed
the
feat-helminstall
branch
from
19accd9 to
93f0a04
Compare
|
use new version #127 |
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note