zfs-import-cache.service fails to start (zpool import with "too many arguments")

[sledz]

System information

Type	Version/Name
Distribution Name	openSUSE
Distribution Version	Leap 15.2
Linux Kernel	5.3.18-lp152.78-preempt
Architecture	x86_64
ZFS Version	2.1.0-rc7
SPL Version	2.1.0-rc7

Describe the problem you're observing

After upgrading from 2.1.0-rc6 to 2.1.0-rc the zfs-import-cache.service fails to start because of error with zpool import.

2021-07-01T11:47:59.730330+02:00 bfg11k systemd[1]: Starting Import ZFS pools by cache file...
2021-07-01T11:47:59.739282+02:00 bfg11k zpool[24770]: too many arguments
2021-07-01T11:47:59.739665+02:00 bfg11k zpool[24770]: usage:
2021-07-01T11:47:59.739946+02:00 bfg11k zpool[24770]: #011import [-d dir] [-D]
2021-07-01T11:47:59.740299+02:00 bfg11k zpool[24770]: #011import [-o mntopts] [-o property=value] ...
2021-07-01T11:47:59.740614+02:00 bfg11k zpool[24770]: #011    [-d dir | -c cachefile] [-D] [-l] [-f] [-m] [-N] [-R root] [-F [-n]] -a
2021-07-01T11:47:59.740802+02:00 bfg11k zpool[24770]: #011import [-o mntopts] [-o property=value] ...
2021-07-01T11:47:59.740962+02:00 bfg11k zpool[24770]: #011    [-d dir | -c cachefile] [-D] [-l] [-f] [-m] [-N] [-R root] [-F [-n]]
2021-07-01T11:47:59.741167+02:00 bfg11k zpool[24770]: #011    [--rewind-to-checkpoint] <pool | id> [newpool]
2021-07-01T11:47:59.741434+02:00 bfg11k systemd[1]: zfs-import-cache.service: Main process exited, code=exited, status=2/INVALIDARGUMENT

Describe how to reproduce the problem

Just reboot.

Include any warning/errors/backtraces from the system logs

First analysis

The update changed a code line from

ExecStart=/usr/sbin/zpool import -c /etc/zfs/zpool.cache -aN

to

ExecStart=/usr/sbin/zpool import -c /etc/zfs/zpool.cache -aN ${ZPOOL_IMPORT_OPTS}

If the ZPOOL_IMPORT_OPTS is empty the trailing space seems to lead to the mentioned problem.

So it seems to be a problem in the zpool command line parameter parsing.

[sledz]

Seems to be cause by #12195

[nabijaczleweli]

Fixed in 83ba91a

[sledz]

Great. Thanx!