Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FreeBSD 13 buildbot is broken #14616

Closed
ryao opened this issue Mar 12, 2023 · 12 comments
Closed

FreeBSD 13 buildbot is broken #14616

ryao opened this issue Mar 12, 2023 · 12 comments
Labels
Component: Test Suite Indicates an issue with the test framework or a test case

Comments

@ryao
Copy link
Contributor

ryao commented Mar 12, 2023

Builds are being done against 13.2-beta3, but FreeBSD has removed the tarballs and now have ones for -rc2 on their website. Perhaps we should have builds done against 13.1 instead for the time being.

@ryao ryao added Component: Test Suite Indicates an issue with the test framework or a test case Type: Defect Incorrect behavior (e.g. crash, hang) and removed Type: Defect Incorrect behavior (e.g. crash, hang) labels Mar 12, 2023
@rincebrain
Copy link
Contributor

I think just repointing it at the stable/13 snapshots is probably The Right Thing to do, since it was failing because it tried to grab src.txz from a URL that stopped existing after a week or so.

Also enhancing the scripts so they don't eat the error output on failure and so failing to grab src.txz is instantly fatal are probably good ideas.

@amotin
Copy link
Member

amotin commented Mar 13, 2023

13.2 should be released by March 27.

@ryao
Copy link
Contributor Author

ryao commented Mar 30, 2023

I think just repointing it at the stable/13 snapshots is probably The Right Thing to do, since it was failing because it tried to grab src.txz from a URL that stopped existing after a week or so.

After thinking about it, I would like to see more branches tested. When the current stable branch is broken, having builds tested against the older stable branch would still be useful because it would warn us about issues like 9fa007d so that we do not merge PRs that break FreeBSD builds.

@brd
Copy link

brd commented Apr 14, 2023

13.2-RELEASE has now shipped so it can be used.

I am interested in this, how can I help?

@ryao
Copy link
Contributor Author

ryao commented Apr 14, 2023

openzfs/zfs-buildbot#272 should fix this.

@behlendorf
Copy link
Contributor

This change has been merged and FreeBSD 13.2 builds are working again.

@lundman
Copy link
Contributor

lundman commented Apr 18, 2023

Are these related?

In file included from /var/lib/buildbot/slaves/zfs/FreeBSD_stable_13_amd64__TEST_/build/zfs/module/os/freebsd/zfs/dmu_os.c:39:
/var/lib/buildbot/slaves/zfs/FreeBSD_stable_13_amd64__TEST_/build/zfs/include/sys/dmu_objset.h:76:15: error: field 'os_meta_dnode' with variable sized type 'dnode_phys_t' (aka 'struct dnode_phys') not at the end of a struct or class is a GNU extension [-Werror,-Wgnu-variable-sized-type-not-at-end]
        dnode_phys_t os_meta_dnode;

@behlendorf
Copy link
Contributor

These are a new errors inadvertently introduced by 27a82cb. We should either revert that change or find some reasonable way to handle the warnings on FreeBSD.

@lundman
Copy link
Contributor

lundman commented Apr 18, 2023

Ah ok, fixed the build bot so it runs, next freebsd can fix the build :)

@behlendorf
Copy link
Contributor

I'd added a comment to #14737 (comment) about this. If you have a preferred way to address this please chime in. We're going to want to do something to resolve this fairly promptly.

@lundman
Copy link
Contributor

lundman commented Apr 18, 2023

I'll have look, I was more worried I had broken it

@youzhongyang
Copy link
Contributor

PR #14763 was created. If you have any better way addressing this issue, please share.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Test Suite Indicates an issue with the test framework or a test case
Projects
None yet
Development

No branches or pull requests

7 participants