Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slot power control breaks build on FreeBSD #15709

Closed
mmatuska opened this issue Dec 25, 2023 · 5 comments
Closed

Slot power control breaks build on FreeBSD #15709

mmatuska opened this issue Dec 25, 2023 · 5 comments
Labels
Type: Defect Incorrect behavior (e.g. crash, hang)

Comments

@mmatuska
Copy link
Contributor

mmatuska commented Dec 25, 2023

a9520e6 breaks build on FreeBSD, as zpool_disk_wait() has not been implemented for FreeBSD

In addition, zpool_power_current_state() and zpool_power() should include (void) lines to suppress unused parameter warnings.

System information

Type Version/Name
Distribution Name FreeBSD
Distribution Version main (freebsd/freebsd-src@9bf957fc9)
Kernel Version freebsd/freebsd-src@9bf957fc9
Architecture amd64
OpenZFS Version zfs-2.2.99-279-g233d34e47

Describe the problem you're observing

OpenZFS cannot be build, as the FreeBSD implementation of zpool_disk_wait() introduced in a9520e6 is missing.

Describe how to reproduce the problem

Try to build OpenZFS

Include any warning/errors/backtraces from the system logs

@mmatuska mmatuska added the Type: Defect Incorrect behavior (e.g. crash, hang) label Dec 25, 2023
@mmatuska mmatuska changed the title a9520e6e5 breaks build on FreeBSD Slot power control breaks build on FreeBSD Dec 25, 2023
@mmatuska
Copy link
Contributor Author

@tonyhutter @behlendorf it would be great to to test at least building on both Linux and FreeBSD before doing commits.

@rincebrain
Copy link
Contributor

It should, but it appears sometime in the last couple days the FreeBSD 13-stable builder stopped running things for some reason, since it reported a failure on #15695...

@tonyhutter
Copy link
Contributor

Yea, looks like buildbot was messed up. I just re-strarted it. Hopefully that and #15716 will get things back to normal.

@rincebrain
Copy link
Contributor

Is there any way we could modify the config so the buildbot failing to report any FBSD tests fails closed, e.g. and blocks the PR merge, rather than failing open?

@mmatuska
Copy link
Contributor Author

Fixed in 07e95b4 #15716

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Defect Incorrect behavior (e.g. crash, hang)
Projects
None yet
Development

No branches or pull requests

3 participants