Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zfs-2.2.3-staging does not compile on FreeBSD #15753

Open
mmatuska opened this issue Jan 11, 2024 · 3 comments
Open

zfs-2.2.3-staging does not compile on FreeBSD #15753

mmatuska opened this issue Jan 11, 2024 · 3 comments
Labels
Type: Defect Incorrect behavior (e.g. crash, hang)

Comments

@mmatuska
Copy link
Contributor

System information

Type Version/Name
Distribution Name FreeBSD
Distribution Version 14.0-STABLE
Kernel Version 38fe4bc08264652cd33964ba6042bd4c0faf6b76
Architecture amd64
OpenZFS Version 2.2.3-staging

Describe the problem you're observing

After backport of 6930ecb (#15675) does zfs-2.2.3-staging not compile on FreeBSD 14.

Describe how to reproduce the problem

Try to compile zfs-2.2.3-staging on FreeBSD 14

Include any warning/errors/backtraces from the system logs

Error output:

cc  -O2 -pipe  -std=gnu99 -Wno-format-zero-length -nobuiltininc -idirafter /usr/lib/clang/16/include -fstack-protector-strong -Wall -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wcast-qual -Wundef -Wno-pointer-sign -D__printf__=__freebsd_kprintf__ -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas -Wno-error=tautological-compare -Wno-error=empty-body -Wno-error=parentheses-equality -Wno-error=unused-function -Wno-error=pointer-sign -Wno-error=shift-negative-value -Wno-address-of-packed-member -Wno-format-zero-length   -Qunused-arguments -Wno-cast-qual   -include /git/zfs/include/os/freebsd/spl/sys/ccompile.h -D__KERNEL__ -DFREEBSD_NAMECACHE -DBUILDING_ZFS -D__BSD_VISIBLE=1 -DHAVE_UIO_ZEROCOPY -DWITHOUT_NETDUMP -D__KERNEL -D_SYS_CONDVAR_H_ -D_SYS_VMEM_H_ -DKDTRACE_HOOKS -DCOMPAT_FREEBSD11 -D__x86_64 -DHAVE_SSE2 -DHAVE_SSSE3 -DHAVE_SSE4_1 -DHAVE_SSE4_2 -DHAVE_AVX -DHAVE_AVX2 -DHAVE_AVX512F -DHAVE_AVX512VL -DHAVE_AVX512BW -DNDEBUG -DBITS_PER_LONG=64 -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -nostdinc  -I/git/zfs/include -I/git/zfs/module/icp/include -I/git/zfs/include/os/freebsd -I/git/zfs/include/os/freebsd/spl -I/git/zfs/include/os/freebsd/zfs -I/git/zfs/module/zstd/include -I/git/zfs/module -include /git/zfs/module/opt_global.h -I. -I/usr/src/sys -I/usr/src/sys/contrib/ck/include -fno-common -g -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -fdebug-prefix-map=./machine=/usr/src/sys/amd64/include -fdebug-prefix-map=./x86=/usr/src/sys/x86/include -fdebug-prefix-map=./i386=/usr/src/sys/i386/include     -MD  -MF.depend.spa.o -MTspa.o -mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float  -fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-protector -Wall -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wcast-qual -Wundef -Wno-pointer-sign -D__printf__=__freebsd_kprintf__ -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas -Wno-error=tautological-compare -Wno-error=empty-body -Wno-error=parentheses-equality -Wno-error=unused-function -Wno-error=pointer-sign -Wno-error=shift-negative-value -Wno-address-of-packed-member -Wno-format-zero-length   -Qunused-arguments -mno-aes -mno-avx -Wno-cast-qual -std=gnu99 -c /git/zfs/module/zfs/spa.c -o spa.o
/git/zfs/module/zfs/spa.c:10501:1: error: too few arguments provided to function-like macro invocation
ZFS_MODULE_VIRTUAL_PARAM_CALL(zfs_zio, zio_, taskq_read,
^
/git/zfs/include/os/freebsd/spl/sys/mod_os.h:53:39: note: expanded from macro 'ZFS_MODULE_VIRTUAL_PARAM_CALL'
#define ZFS_MODULE_VIRTUAL_PARAM_CALL ZFS_MODULE_PARAM_CALL
                                      ^
/git/zfs/include/os/freebsd/spl/sys/mod_os.h:50:2: note: expanded from macro 'ZFS_MODULE_PARAM_CALL'
        ZFS_MODULE_PARAM_CALL_IMPL(_vfs_ ## scope_prefix, name, perm, \
        ^
/git/zfs/include/os/freebsd/spl/sys/mod_os.h:46:75: note: expanded from macro 'ZFS_MODULE_PARAM_CALL_IMPL'
    SYSCTL_PROC(parent, OID_AUTO, name, CTLFLAG_MPSAFE | perm | args, desc)
                                                                          ^
/usr/src/sys/sys/sysctl.h:815:9: note: macro 'SYSCTL_PROC' defined here
#define SYSCTL_PROC(parent, nbr, name, access, ptr, arg, handler, fmt, descr) \
        ^
/git/zfs/module/zfs/spa.c:10501:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Werror,-Wimplicit-int]
ZFS_MODULE_VIRTUAL_PARAM_CALL(zfs_zio, zio_, taskq_read,
^
/git/zfs/include/os/freebsd/spl/sys/mod_os.h:53:39: note: expanded from macro 'ZFS_MODULE_VIRTUAL_PARAM_CALL'
#define ZFS_MODULE_VIRTUAL_PARAM_CALL ZFS_MODULE_PARAM_CALL
                                      ^
/git/zfs/include/os/freebsd/spl/sys/mod_os.h:50:2: note: expanded from macro 'ZFS_MODULE_PARAM_CALL'
        ZFS_MODULE_PARAM_CALL_IMPL(_vfs_ ## scope_prefix, name, perm, \
        ^
/git/zfs/include/os/freebsd/spl/sys/mod_os.h:46:5: note: expanded from macro 'ZFS_MODULE_PARAM_CALL_IMPL'
    SYSCTL_PROC(parent, OID_AUTO, name, CTLFLAG_MPSAFE | perm | args, desc)
    ^
/git/zfs/module/zfs/spa.c:10504:1: error: too few arguments provided to function-like macro invocation
ZFS_MODULE_VIRTUAL_PARAM_CALL(zfs_zio, zio_, taskq_write,
^
/git/zfs/include/os/freebsd/spl/sys/mod_os.h:53:39: note: expanded from macro 'ZFS_MODULE_VIRTUAL_PARAM_CALL'
#define ZFS_MODULE_VIRTUAL_PARAM_CALL ZFS_MODULE_PARAM_CALL
                                      ^
/git/zfs/include/os/freebsd/spl/sys/mod_os.h:50:2: note: expanded from macro 'ZFS_MODULE_PARAM_CALL'
        ZFS_MODULE_PARAM_CALL_IMPL(_vfs_ ## scope_prefix, name, perm, \
        ^
/git/zfs/include/os/freebsd/spl/sys/mod_os.h:46:75: note: expanded from macro 'ZFS_MODULE_PARAM_CALL_IMPL'
    SYSCTL_PROC(parent, OID_AUTO, name, CTLFLAG_MPSAFE | perm | args, desc)
                                                                          ^
/usr/src/sys/sys/sysctl.h:815:9: note: macro 'SYSCTL_PROC' defined here
#define SYSCTL_PROC(parent, nbr, name, access, ptr, arg, handler, fmt, descr) \
        ^
/git/zfs/module/zfs/spa.c:10504:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Werror,-Wimplicit-int]
ZFS_MODULE_VIRTUAL_PARAM_CALL(zfs_zio, zio_, taskq_write,
^
/git/zfs/include/os/freebsd/spl/sys/mod_os.h:53:39: note: expanded from macro 'ZFS_MODULE_VIRTUAL_PARAM_CALL'
#define ZFS_MODULE_VIRTUAL_PARAM_CALL ZFS_MODULE_PARAM_CALL
                                      ^
/git/zfs/include/os/freebsd/spl/sys/mod_os.h:50:2: note: expanded from macro 'ZFS_MODULE_PARAM_CALL'
        ZFS_MODULE_PARAM_CALL_IMPL(_vfs_ ## scope_prefix, name, perm, \
        ^
/git/zfs/include/os/freebsd/spl/sys/mod_os.h:46:5: note: expanded from macro 'ZFS_MODULE_PARAM_CALL_IMPL'
    SYSCTL_PROC(parent, OID_AUTO, name, CTLFLAG_MPSAFE | perm | args, desc)
    ^
4 errors generated.
*** Error code 1
@mmatuska mmatuska added the Type: Defect Incorrect behavior (e.g. crash, hang) label Jan 11, 2024
@mmatuska
Copy link
Contributor Author

@robn ping thanks

@robn robn mentioned this issue Jan 11, 2024
Merged
13 tasks
@robn
Copy link
Member

robn commented Jan 11, 2024

@mmatuska My mistake, sorry about that! Thanks for letting me know. #15754 should take care of it.

@robn
Copy link
Member

robn commented Jan 11, 2024

Also #15755 for 2.1.15. No idea if anyone wants it; 2.1 was already not compiling on FreeBSD 14, but might as well get it right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Defect Incorrect behavior (e.g. crash, hang)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@robn @mmatuska