Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return boolean_t in inline functions of lib/libspl/include/sys/uio.h #16613

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Return boolean_t in inline functions of lib/libspl/include/sys/uio.h #16613

merged 1 commit into from
Oct 7, 2024

Conversation

mmatuska
Copy link
Contributor

@mmatuska mmatuska commented Oct 7, 2024

Motivation and Context

The inline functions zfs_dio_offset_aligned(), zfs_dio_size_aligned() and zfs_dio_aligned() are declared as boolean_t but return the bool type.

This fixes the build of FreeBSD zstd.

Description

Change return type to boolean_t

How Has This Been Tested?

Build of zstd on FreeBSD

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@mmatuska
Return boolean_t in inline functions of lib/libspl/include/sys/uio.h
1731e56 
The inline functions zfs_dio_offset_aligned(), zfs_dio_size_aligned()
and zfs_dio_aligned() are declared as boolean_t but return the bool
type.

This fixes the build of FreeBSD zstd.

Signed-off-by: Martin Matuska <mm@FreeBSD.org>
amotin
amotin approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@amotin amotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that I object, but wonder how does it break the build and how is it related to zstd? Or did you mean zfsd and its C++?

@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Oct 7, 2024
@behlendorf behlendorf merged commit ab777f4 into openzfs:master Oct 7, 2024
18 of 20 checks passed
ixhamza pushed a commit to truenas/zfs that referenced this pull request Oct 8, 2024
@mmatuska @ixhamza
Return boolean_t in inline functions of lib/libspl/include/sys/uio.h
ed9db9d 
The inline functions zfs_dio_offset_aligned(), zfs_dio_size_aligned()
and zfs_dio_aligned() are declared as boolean_t but return the bool
type.

This fixes the build of FreeBSD.

Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Martin Matuska <mm@FreeBSD.org>
Closes openzfs#16613
ixhamza pushed a commit to truenas/zfs that referenced this pull request Oct 8, 2024
@mmatuska @ixhamza
Return boolean_t in inline functions of lib/libspl/include/sys/uio.h
3398168 
The inline functions zfs_dio_offset_aligned(), zfs_dio_size_aligned()
and zfs_dio_aligned() are declared as boolean_t but return the bool
type.

This fixes the build of FreeBSD.

Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Martin Matuska <mm@FreeBSD.org>
Closes openzfs#16613
@mmatuska
Copy link
Contributor Author

mmatuska commented Oct 8, 2024

@amotin yes the C++ build

ixhamza pushed a commit to truenas/zfs that referenced this pull request Oct 9, 2024
@mmatuska @ixhamza
Return boolean_t in inline functions of lib/libspl/include/sys/uio.h
937b567 
The inline functions zfs_dio_offset_aligned(), zfs_dio_size_aligned()
and zfs_dio_aligned() are declared as boolean_t but return the bool
type.

This fixes the build of FreeBSD.

Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Martin Matuska <mm@FreeBSD.org>
Closes openzfs#16613
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Oct 9, 2024
@mmatuska @behlendorf
Return boolean_t in inline functions of lib/libspl/include/sys/uio.h
84f44ec 
The inline functions zfs_dio_offset_aligned(), zfs_dio_size_aligned()
and zfs_dio_aligned() are declared as boolean_t but return the bool
type.

This fixes the build of FreeBSD.

Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Martin Matuska <mm@FreeBSD.org>
Closes openzfs#16613
ixhamza pushed a commit to truenas/zfs that referenced this pull request Oct 9, 2024
@mmatuska @ixhamza
Return boolean_t in inline functions of lib/libspl/include/sys/uio.h
74dece5 
The inline functions zfs_dio_offset_aligned(), zfs_dio_size_aligned()
and zfs_dio_aligned() are declared as boolean_t but return the bool
type.

This fixes the build of FreeBSD.

Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Martin Matuska <mm@FreeBSD.org>
Closes openzfs#16613
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amotin amotin amotin approved these changes

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmatuska @behlendorf @amotin