Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use python-libzim #136

Closed
kelson42 opened this issue Jul 13, 2020 · 4 comments · Fixed by #157
Closed

Use python-libzim #136

kelson42 opened this issue Jul 13, 2020 · 4 comments · Fixed by #157
Assignees
@benoit74
Labels
enhancement
Milestone
2.0.0

Comments

@kelson42
Copy link
Contributor

in place of zimwriterfs
@kelson42 kelson42 pinned this issue Jul 13, 2020
@stale
Copy link

stale bot commented Sep 11, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Sep 11, 2020
@stale stale bot removed the stale label Jan 12, 2021
@stale
Copy link

stale bot commented Mar 19, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Mar 19, 2021
@kelson42 kelson42 mentioned this issue Jul 31, 2021
Closed
@kelson42 kelson42 added this to the 1.2.0 milestone Dec 17, 2022
@stale stale bot removed the stale label Dec 17, 2022
@kelson42 kelson42 mentioned this issue Dec 20, 2022
Open
@benoit74
Copy link
Collaborator

benoit74 commented Jan 6, 2023

FYI, I'm also preparing a PR on this one, it is hard to test #156 while still relying on zimwriterfs + I already gained a significant experience on zimscraperlib ^^
Already have something working for JS files + authors HTML file, hopefully close to a first prototype (hardest part is probably around progress reporting)

@rgaudin
Copy link
Member

rgaudin commented Jan 6, 2023

Great! Maybe leave progress reporting for a second time? Switching to libzim would be a great achievement already

@benoit74 benoit74 mentioned this issue Jan 7, 2023
Merged
@kelson42 kelson42 unpinned this issue Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benoit74 benoit74

Labels
enhancement
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Use zimscraperlib (in place of zimwriterfs) + upgrade to Python 3.11 + dependencies
3 participants
@rgaudin @kelson42 @benoit74