Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better default UI #42

Closed
Popolechien opened this issue May 17, 2023 · 6 comments
Closed

Better default UI #42

Popolechien opened this issue May 17, 2023 · 6 comments
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@Popolechien
Copy link

Popolechien commented May 17, 2023

Current UI is minimalist (or non-existent) and we should import / reproduce the existing UI.

Here is for instance the layout for Algebra 1:
Capture d’écran 2023-05-17 à 15 44 07

And how it comes out on the zim:
Capture d’écran 2023-05-17 à 15 44 18

And then going further into Algebra foundations:
Capture d’écran 2023-05-17 à 15 45 35

and on the zim
Capture d’écran 2023-05-17 à 15 46 24

@Popolechien Popolechien added the enhancement New feature or request label May 17, 2023
@rgaudin
Copy link
Member

rgaudin commented May 17, 2023

@Popolechien this is not what we discussed ; we discussed recreating the Endless UI. Or did I get it all wrong? @kelson42 ?

https://key.endlessos.org/en/explore/#/topics/c9d7f950ab6b5a1199e3d6c10d7f0103

Screenshot 2023-05-17 at 14 16 10

@rgaudin rgaudin changed the title Implement Khan Academy UI Better default UI May 17, 2023
@Popolechien
Copy link
Author

My bad - for some reason I stayed with the impression that endless had reproduced the Khan UI

@benoit74
Copy link
Collaborator

I split this issue into multiple smaller ones.

@benoit74 benoit74 removed this from the 1.2.0 milestone Oct 12, 2023
@benoit74 benoit74 added the question Further information is requested label Oct 12, 2023
@benoit74
Copy link
Collaborator

@kelson42 @Popolechien
Is it ok for you if we release the scraper with only one of the subtasks completed (the minimal first step)? I think this first step is already a great enhancement. Completing all subtasks is a long term effort which would probably needs financing.

@benoit74
Copy link
Collaborator

Nota: if we decide to release only the minimal first step, maybe we should wait for #64 as well before releasing the scraper

@benoit74
Copy link
Collaborator

I close this issue, issue has been splitted in many smaller ones.
Code is made ready in the new_ui branch.
All mandatory features for a release to main are tagged in the 1.2.0 milestone.

@benoit74 benoit74 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants