Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem about tree structure of a page #1501

Open
zkosk opened this issue Jul 19, 2021 · 10 comments
Open

Problem about tree structure of a page #1501

zkosk opened this issue Jul 19, 2021 · 10 comments
Labels
bug good first issue wikimedia Direct impact on Wikimedia content scraping
Milestone

Comments

@zkosk
Copy link

zkosk commented Jul 19, 2021

In the page "Perturbation_theory_(quantum_mechanics)", some subtree are put at the same level as their parent:
image

"Generalization to multi-parameter case" is the parent node, all the others in the picture are its child nodes. But they are not hidden then the parent is collapsed. Not sure whether it is a problem of online Wiki or the offliner tool.

maxi Version "6,134,097 articles in English"

@kelson42
Copy link
Collaborator

@kelson42 kelson42 added bug wikimedia Direct impact on Wikimedia content scraping labels Jul 20, 2021
@kelson42 kelson42 added this to the 1.12 milestone Jul 20, 2021
@kelson42 kelson42 pinned this issue Jul 20, 2021
@stale
Copy link

stale bot commented Sep 21, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Sep 21, 2021
@kelson42 kelson42 modified the milestones: 1.12, 1.11.11 Sep 26, 2021
@stale stale bot removed the stale label Sep 26, 2021
@MananJethwani
Copy link
Contributor

@kelson42 the current implementation for tree structure considers dropdown structure to be followed only for the first level, and puts all others on the same level, as far as I remember this was discussed in some other issue as well, do you want me to implement a proper method that might use recursion or stack to implement a proper tree structure. or the current method should be kept?

@kelson42
Copy link
Collaborator

kelson42 commented Oct 2, 2021

@MananJethwani I really wonder about that. Sounds kind of "crazy". Obviously it has to manage an indefinite level of depth.

@the-illuminatus
Copy link

is the issue still open?

@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Apr 16, 2022
@kelson42 kelson42 modified the milestones: 1.13.0, 1.12.0 Oct 16, 2022
@stale stale bot removed stale labels Jan 2, 2023
@kelson42
Copy link
Collaborator

kelson42 commented Jan 2, 2023

Wondering if this makes sense to implement this just before #1664?!

@Jaifroid
Copy link
Collaborator

Jaifroid commented Jan 3, 2023

Personally I'd agree that #1664 is higher priority, and it's possible it could make this issue redundant. But we won't know that till the new endpoint has been implemented.

@kelson42
Copy link
Collaborator

Lets implement #1664 first

@teraspora
Copy link

@zkosk @kelson42 In Chrome Version 126.0.6478.182 (Official Build) (64-bit) and Firefox 128.0 (64-bit) I don't see the arrows on either the parent or child nodes: the content is not collapsible.

So it would appear that this is not now an issue.

However, if it still occurs in some browser then can you provide a link to example content and browser name/version? Then I will be happy to have a look at it. Else should this issue be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue wikimedia Direct impact on Wikimedia content scraping
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants
@kelson42 @Jaifroid @teraspora @pavel-karatsiuba @MananJethwani @zkosk @the-illuminatus and others