Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure format option is working for WikimediaMobile renderer #1916

Closed
VadimKovalenkoSNF opened this issue Sep 22, 2023 · 5 comments · Fixed by #1903
Closed

Make sure format option is working for WikimediaMobile renderer #1916

VadimKovalenkoSNF opened this issue Sep 22, 2023 · 5 comments · Fixed by #1903
Assignees
Labels
Milestone

Comments

@VadimKovalenkoSNF
Copy link
Collaborator

Format options (nopic, nodet, novid, nopdf) should be covered by tests and fixed if necessary for WikimediaMobile renderer. The work around this renderer is here: #1903

@kelson42 kelson42 added the task label Oct 1, 2023
@kelson42 kelson42 added this to the 1.14.0 milestone Oct 1, 2023
@kelson42
Copy link
Collaborator

kelson42 commented Oct 1, 2023

AFAIK, nopic and nodet work.

@kelson42
Copy link
Collaborator

kelson42 commented Oct 4, 2023

@VadimKovalenkoSNF Any news here?

@VadimKovalenkoSNF
Copy link
Collaborator Author

There has been manual testing of nopic and nodet described here - #1903 (comment)
Test of novid and nopdf in progress.

@VadimKovalenkoSNF
Copy link
Collaborator Author

VadimKovalenkoSNF commented Oct 4, 2023

@kelson42 , .nopdf option doesn't work for desktop and mobile renders. Others work as expected, I made a separate test suit for them in #1903

Upd: nopdf sometimes works for desktop and mobile, I just didn't understand its principle at first glance. If nopdf is set, then links to pdf files are not written to the zim but links to commons wiki (or other initial pdf storage) are preserved. By sometimes I meant that I tried this article with nopdf and without and got the same output even for desktop render (check links to pdf files):

npm start -- --mwUrl=https://en.wikipedia.org --adminEmail=mail@mail.com --articleList=PDF --format=nopdf

Is this a bug?

@kelson42
Copy link
Collaborator

@VadimKovalenkoSNF Please open a ticket for nopdf and close this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants