Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inputs (in particular the collection.json) should be checked #29

Closed
kelson42 opened this issue Sep 14, 2021 · 5 comments
Closed

Inputs (in particular the collection.json) should be checked #29

kelson42 opened this issue Sep 14, 2021 · 5 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@kelson42
Copy link
Contributor

kelson42 commented Sep 14, 2021

See #28. After many iterations we have achieved to buidl a ZIM, but the ZIM is incorrect and we have no clue why.

The check should, at start, verify that everything is OK (and reports/stops otherwise):

  • Key inputs/files are downloadable
  • Key values are available in the JSON
  • JSON values are correct, in particular the files
  • ...
@kelson42 kelson42 added the enhancement New feature or request label Sep 14, 2021
@kelson42 kelson42 changed the title Inputs (in particula the collection.json) should be checked Inputs (in particular the collection.json) should be checked Sep 14, 2021
@stale
Copy link

stale bot commented Mar 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Mar 2, 2022
@kelson42 kelson42 pinned this issue Sep 24, 2022
@stale stale bot removed the stale label Sep 24, 2022
@stale
Copy link

stale bot commented May 26, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label May 26, 2023
@kelson42 kelson42 added this to the 1.2.0 milestone Mar 23, 2024
@stale stale bot removed the stale label Mar 23, 2024
@kelson42 kelson42 modified the milestones: 1.2.0, 2.0.0 May 10, 2024
@rgaudin
Copy link
Member

rgaudin commented May 13, 2024

This is mostly obsolete. JSON is the source of trust and entries are checked early.
Only recent URL entries are not completely checked

@rgaudin rgaudin unpinned this issue May 13, 2024
@kelson42
Copy link
Contributor Author

@rgaudin I don't understand your last comment: do we check data in json are correct? If "yes, how? If "no", why this doesnot matter?

@rgaudin
Copy link
Member

rgaudin commented May 13, 2024

JSON entries are either a references to a file in the ZIP archive (if using one) or an arbitrary URL.
If an URL, we check that the URL works (HTTP 200) ; if not, we check that it is indeed inside the ZIP.

@kelson42 kelson42 modified the milestones: 2.0.0, 1.2.0 May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants