-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove inline javascript to comply with some CSP #168
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions. |
Moreover, the scripts seem to break out of our iframe, and navigate the top-level document, which then destroys the Kiwix JS reader. There was a similar case with Stackexchange ZIMs when the new Type 1 ZIM type was introduced, but @rgaudin fixed it. |
This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions. |
Tested with https://download.kiwix.org/zim/mooc/phzh_core-english-one_en_2021-07.zim
There are many inline javascripts, that should be moved to javascript files:
And some onclick attributes like:
The text was updated successfully, but these errors were encountered: