Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Titles of Redirect Entries do not Show Up in Search Results #388

Closed
kelson42 opened this issue Dec 4, 2023 · 5 comments · Fixed by #387
Closed

Titles of Redirect Entries do not Show Up in Search Results #388

kelson42 opened this issue Dec 4, 2023 · 5 comments · Fixed by #387
Assignees
Milestone

Comments

@kelson42
Copy link
Contributor

kelson42 commented Dec 4, 2023

From kiwix-android created by gremid: kiwix/kiwix-android#3559

Describe the bug
When searching for titles, titles of redirect entries do not appear in the results. In the case of the DWDS custom app, we have about 16,000 redirect entries for alternative spellings of dictionary entries (i. e. "Delphin" vs. "Delfin") and while the major spelling variant can be found in the title search (i. e. "Delfin"), the alternative spelling does not show up (i. e. "Delphin").

Expected behavior

Both types of ZIM entries, content as well as redirect entries, should be indexed and searchable.

Steps to reproduce the behavior:

  1. Open the DWDS custom app.
  2. Search for "Delphin" vs. "Delfin".

Environment

  • Version of Kiwix Android : DWDS Custom App 2023-11-20 Build: 7233250
  • Device : Redmi Note 0S
  • OS version : Android 13 TP1A.220624.014
@kelson42
Copy link
Contributor Author

kelson42 commented Dec 4, 2023

@gremid Definitly agree. I will check on my side, we have here maybe a bug in Zimwriterfs. I will do the investigation.

@kelson42
Copy link
Contributor Author

kelson42 commented Dec 4, 2023

@gremid I confirm the problem, this is not a problem with Kiwix-Android. This is a general problem and I believe that indeed the redirects are not indexed in the ZIM. You confirm you created this ZIM with the latest zimwriterfs with the option --redirects?
@mgautierfr You confirm that zimwriterfs indexes the redirects properly in the Xapian Title index? If "yes", what goes wrong here?

Here is the entry in the ZIM:

path: wb/Delphin
* title:          Delphin
* idx:            30476
* type:           redirect
* redirect index: 30431

@kelson42
Copy link
Contributor Author

kelson42 commented Dec 4, 2023

@mgautierfr I guess the problem is that in zimwriterfs, ZimCreatorFS::add_redirectArticles_from_file() does not have any hint?! I "yes", can you please make a fix.

@kelson42
Copy link
Contributor Author

kelson42 commented Dec 4, 2023

The latest ZIM dwds_de_dictionary_nopic_2023-11-20.zim is built with zimwriterfs of zim-tools 3.3.0 and libzim 9.0.0.

@kelson42
Copy link
Contributor Author

kelson42 commented Dec 4, 2023

@gremid We have fixed the bug. Tomorrow, in the nightlies, you will have a new version of zimwriterfs which should work as expected. I will try to make an official release of the zim-tools this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants