Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to pause worker scheduling #1022

Open
benoit74 opened this issue Oct 4, 2024 · 1 comment
Open

Add ability to pause worker scheduling #1022

benoit74 opened this issue Oct 4, 2024 · 1 comment

Comments

@benoit74
Copy link
Collaborator

benoit74 commented Oct 4, 2024

Currently when one want the manager to stop starting new task, it is needed to completely stop the container.

This has many drawbacks:

  • worker seems dead in the UI while it is just paused from starting new tasks
  • should the machine reboot or docker restart, the manager will restart automatically and begin again to accept new task
  • all other duties of the manager are not performed anymore (e.g. atm cancelling tasks that need to be)

I think it would help to create a new status for the worker : cordon (to reuse k8s term) or scheduling_disabled

In this status the worker would just stop starting new tasks but will continue all the rest of its duties.

This should probably be configured in /etc/zimfarm.config (needing a manager restart, but this is not a problem)

This status should be reported during check-in, stored in DB, displayed in UI.

@rgaudin
Copy link
Member

rgaudin commented Oct 4, 2024

Can be done by toggling the OFFLINERS conf to empty in that same file in the mean time ; or by setting SELFISH (not exactly equivalent but would work for most cases)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants