Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dapper&opentracing #22

Closed
yzfshuijing opened this issue Mar 10, 2017 · 4 comments
Closed

dapper&opentracing #22

yzfshuijing opened this issue Mar 10, 2017 · 4 comments

Comments

@yzfshuijing
Copy link

I have a question, zipkin is based on dapper, and cs,cr,ss,sr have the same spanid. But in opentracing, cs,cr and ss,sr do not have the same span id ,and they have a child of relationship. Is that may have some influence?
Looking forward for your answer!

@codefromthecrypt
Copy link
Contributor

codefromthecrypt commented Mar 10, 2017 via email

@yzfshuijing
Copy link
Author

thanks for your answer, in brave-opentracing,
public final Span joinSpan(TraceContext context) , public Span newTrace(SamplingFlags samplingFlags)
the above two functions
so in remote operations, if i want to use the same span, i can just use joinSpan, if not just use newTrace.
is that right?

@codefromthecrypt
Copy link
Contributor

actually, you'd want to use newChild as newTrace should only be used when an existing trace can't be read (as it restarts a trace) cc @reta

@yzfshuijing
Copy link
Author

oh i see, thanks so much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants