Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for non-blocking sending messages to kafka producer #150

Closed
nemanjamikic opened this issue Oct 2, 2019 · 1 comment
Closed

Support for non-blocking sending messages to kafka producer #150

nemanjamikic opened this issue Oct 2, 2019 · 1 comment

Comments

@nemanjamikic
Copy link

Zipkin is not critical component to work. If the kafka producer channel buffer is full messages should be just logged instead of waiting for space in buffer. There should be option when creating kafkaReporter to specify if you want to be non-blocking and time for timeout. This allows current request not to wait for space in channel buffer if there is none.

Here are changes a97fc6c
and pull requests: #149

@nemanjamikic
Copy link
Author

Can somebody take a look?
CC @abesto @adriancole @rogpeppe @skaslev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants