New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't include the http.status_code when 2xx in server #162

Closed

jcchavezs opened this issue Mar 31, 2020 · 2 comments

Contributor

jcchavezs commented Mar 31, 2020

According to https://github.com/openzipkin/brave/blob/master/instrumentation/http/src/main/java/brave/http/HttpResponseParser.java#L67, by default http.status_code tag should only be present if the tag is not 2xx. It makes sense to replicate this condition here in server instrumentation given that client does it already.

The text was updated successfully, but these errors were encountered:

Contributor

dengliming commented Aug 10, 2020

+1

dengliming mentioned this issue

Don't include the http.status_code when 2xx in server. #167

Merged

jcchavezs closed this as completed

Contributor Author

jcchavezs commented Aug 10, 2020

Thanks @dengliming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment