-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: async_hooks based context #124
Comments
Might be worth taking a look at a bridge for cls: https://www.npmjs.com/package/cls-hooked |
Another alternative: https://www.npmjs.com/package/asyncctx |
Can use the below package instead of zipkin-context-cls for supporting async await. |
@anujshankar :) |
Is there an approach that doesn't use async hooks? There currently are performance issues with async hooks. |
@mziemer21 not at the moment. Actually this is a good input for this discussion #201 (comment) cc @adriancole |
More relevant information: DataDog/dd-trace-js#695 |
Node 8 has a new async hooks module, which should be able to replace
zipkin-context-cls
entirely, as well as work better (i.e. at all) for promises.It's still experimental, but not behind a flag. No polyfills exists for older nodes (lots of C++ in the implementation, so probably not incoming either).
https://nodejs.org/api/async_hooks.html
Obligatory hype blog post: https://medium.com/the-node-js-collection/async-hooks-in-node-js-illustrated-b7ce1344111f &
/cc @sveisvei (#65 (comment))
The text was updated successfully, but these errors were encountered: