Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding arbitrary tags on span #502

Open
maximede opened this issue May 18, 2020 · 1 comment
Open

Allow adding arbitrary tags on span #502

maximede opened this issue May 18, 2020 · 1 comment

Comments

@maximede
Copy link

I'd like to be able to add tags on a span, at runtime.

Similar to what brave does https://github.com/openzipkin/brave/blob/master/brave/README.md#customizing-spans

span.tag("clnt/finagle.version", "6.36.0");
@jcchavezs
Copy link
Contributor

As per our chat @maximede:

The main idea is to support default tags on the client/server instrumentation. Similar to what it is on https://github.com/openzipkin/zipkin-js/blob/e68cc61/packages/zipkin/src/tracer/index.js#L40 but for httpClient and httpServer.

Implementation should be as easy as adding another parameter to https://github.com/openzipkin/zipkin-js/blob/e68cc61/packages/zipkin/src/instrumentation/httpClient.js#L9 declaring the tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants