We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I'd like to be able to add tags on a span, at runtime.
Similar to what brave does https://github.com/openzipkin/brave/blob/master/brave/README.md#customizing-spans
brave
span.tag("clnt/finagle.version", "6.36.0");
The text was updated successfully, but these errors were encountered:
As per our chat @maximede:
The main idea is to support default tags on the client/server instrumentation. Similar to what it is on https://github.com/openzipkin/zipkin-js/blob/e68cc61/packages/zipkin/src/tracer/index.js#L40 but for httpClient and httpServer.
httpClient
httpServer
Implementation should be as easy as adding another parameter to https://github.com/openzipkin/zipkin-js/blob/e68cc61/packages/zipkin/src/instrumentation/httpClient.js#L9 declaring the tags.
Sorry, something went wrong.
No branches or pull requests
I'd like to be able to add tags on a span, at runtime.
Similar to what
brave
does https://github.com/openzipkin/brave/blob/master/brave/README.md#customizing-spansThe text was updated successfully, but these errors were encountered: