added an error handler for zipkin-web #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 from me, but Franklin is probably a better reviewer for this one |
… exist in Finatra. I submitted a patch to finatra, and it was accepted, and julio rolled a release, but it depends on finagle 6 which breaks our dependency tree. Sooo I'm forced to put this code in here with a FIXME because I want the feature.
|
+1 |
bmdhacks
pushed a commit
that referenced
this pull request
Mar 12, 2013
Error handling for zipkin-web. Before we were returning an empty document if a downstream exception happened, now we print the stacktrace to the screen. There is some hackish code in here that is needed until we upgrade to Finatra 1.3.0 + Finagle 6 + Cassie 0.?? (cassie not released yet)
codefromthecrypt
pushed a commit
that referenced
this pull request
Jun 3, 2016
…tions Per #233, we need to be very explicit about mysql not being the choice for big data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't fully work until we integrate with my patch to finatra, but I'm submitting this now because it's done. Once finatra releases the new version we'll change the build and it will all be happy.