Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special case Elasticsearch 7.8+ Composable index templates #3138

Open
codefromthecrypt opened this issue Jul 6, 2020 · 1 comment
Open
Labels
elasticsearch Elasticsearch storage component enhancement help wanted

Comments

@codefromthecrypt
Copy link
Member

codefromthecrypt commented Jul 6, 2020

Feature:
If we prefer composable templates or otherwise prioritize our index templates, we can avoid support problems like openzipkin/zipkin-support#23 where the template doesn't kick in due to something else matching on '*'

Rational
Composeable templates are both introduced and preferred in ES 7.8+, which refers to _template as legacy ones.

This would introduce an issue of composeable template priority, either it would have to determine automatically what value should be set or be parameterizable through env variable.

Example Scenario
Test would have a pre-existing composable template and ours still applies

Thanks @benqs for the hint. cc @openzipkin/elasticsearch

@xeraa
Copy link
Member

xeraa commented Jul 7, 2020

BTW this is part of a bigger change around time-based indices that will lead to data streams; though that is still work in progress. So I would wait a little longer here and see if that might make sense for Zipkin as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
elasticsearch Elasticsearch storage component enhancement help wanted
Projects
None yet
Development

No branches or pull requests

2 participants