Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timestampRange calculation error due to int variable instead of long #3357

Closed
ilseucolling opened this issue Jul 5, 2021 · 0 comments · Fixed by #3367
Closed

timestampRange calculation error due to int variable instead of long #3357

ilseucolling opened this issue Jul 5, 2021 · 0 comments · Fixed by #3367
Labels
bug

Comments

@ilseucolling
Copy link

timestampRange calculation error due to int variable instead of long

CassandraSpanStore.java

Change needed from:
final int indexTtl;

To:
final long indexTtl

It will calculate wrong if TTL from table is set for 7890000.

The result will be a bucket from the future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes int overflow issue for large TTL values vy8/zipkin
1 participant
@ilseucolling