edge client api link factories are too indiscriminate

[sabedevops]

ziti version: 0.26.10

Requests to the edge client api endpoints produce _links which are unfiltered for non-admin identities. These links cannot be followed by the client successfully as the identity lack permissions.

Example:

GET /edge/client/v1/services

{
  "_links": {
    "configs": {
      "href": "./services/6poaOHbjacJdG2wrZqhyND/configs"
    },
    "self": {
      "href": "./services/6poaOHbjacJdG2wrZqhyND"
    },
    "service-edge-router-policies": {
      "href": "./services/6poaOHbjacJdG2wrZqhyND/service-edge-router-policies"
    },
    "service-policies": {
      "href": "./services/6poaOHbjacJdG2wrZqhyND/service-policies"
    },
    "terminators": {
      "href": "./services/6poaOHbjacJdG2wrZqhyND/terminators"
    }
}

Attempt to follow _links.configs.

GET /edge/client/v1/services/6poaOHbjacJdG2wrZqhyND/configs

{
  "error": {
    "cause": {
      "code": "UNHANDLED",
      "message": "path /edge/client/v1/services/6poaOHbjacJdG2wrZqhyND/configs was not found"
    },
    "code": "NOT_FOUND",
    "message": "The resource requested was not found or is no longer available",
    "requestId": "B1TtnV.xng"
  },
  "meta": {
    "apiEnrollmentVersion": "0.0.1",
    "apiVersion": "0.0.1"
  }
}

[ekoby]

clean up the links

[qrkourier]

Here's what I get with 1.1.8 for /edge/client/v1/services

{
  "data": [
    {
      "_links": {
        "configs": {
          "href": "./services/6H9WrKOM1fLnitRRZ7B018/configs"
        },
        "self": {
          "href": "./services/6H9WrKOM1fLnitRRZ7B018"
        },
        "service-edge-router-policies": {
          "href": "./services/6H9WrKOM1fLnitRRZ7B018/service-edge-router-policies"
        },
        "service-policies": {
          "href": "./services/6H9WrKOM1fLnitRRZ7B018/service-policies"
        },
        "terminators": {
          "href": "./services/6H9WrKOM1fLnitRRZ7B018/terminators"
        }
      },
      "createdAt": "2024-07-24T15:21:21.974Z",
      "id": "6H9WrKOM1fLnitRRZ7B018",
      "tags": {},
      "updatedAt": "2024-07-24T15:21:21.974Z",
      "config": {},
      "configs": null,
      "encryptionRequired": true,
      "maxIdleTimeMillis": 0,
      "name": "kentest",
      "permissions": [
        "Invalid"
      ],
      "postureQueries": [
        {
          "isPassing": true,
          "policyId": "dummy invalid policy: no posture checks defined",
          "policyType": "Invalid",
          "postureQueries": []
        }
      ],
      "roleAttributes": null,
      "terminatorStrategy": "smartrouting"
    }
  ],
  "meta": {
    "filterableFields": [
      "isSystem",
      "terminatorStrategy",
      "updatedAt",
      "tags",
      "roleAttributes",
      "name",
      "id",
      "createdAt",
      "configs"
    ],
    "pagination": {
      "limit": 10,
      "offset": 0,
      "totalCount": 1
    }
  }
}