Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signal CatalogSource Ready status #8

Closed
everettraven opened this issue Mar 27, 2023 · 2 comments · Fixed by #17
Closed

Signal CatalogSource Ready status #8

everettraven opened this issue Mar 27, 2023 · 2 comments · Fixed by #17
Milestone
v0.1.0

Comments

@everettraven
Copy link
Collaborator

We should modify the CatalogSource CRD to signal in it's status, when a CR is ready.

Definition of ready: When the CatalogSource controller is done parsing the content of the image,and the content is available on cluster, ready to be queried by clients.
@everettraven everettraven mentioned this issue Mar 30, 2023
Merged
@joelanford
Copy link
Member

joelanford commented Mar 30, 2023 •
edited
Loading

In addition, we should update the status with all the different scenarios:

  • currently unpacking (with any relevant messages about the unpacking progress)
  • unpacking failed (with the reason it failed)

And we should use standard Conditions []metav1.Condition in the status.

@everettraven
Copy link
Collaborator Author

everettraven commented Mar 30, 2023 •
edited
Loading

@joelanford I created a separate issue for setting status based on errors and other states and improving the error handling here: #6

@anik120 anik120 added this to the v0.1.0 milestone Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging a pull request may close this issue.

(feat): Communicate "Ready" Status of CatalogSource CR everettraven/catalogd
3 participants
@joelanford @anik120 @everettraven