Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Deppy to be imported by other packages #73

Closed
2 tasks
oceanc80 opened this issue Nov 30, 2022 · 4 comments · Fixed by #82
Closed
2 tasks

Enable Deppy to be imported by other packages #73

oceanc80 opened this issue Nov 30, 2022 · 4 comments · Fixed by #82
Labels
olm-v1/m1 OLM v1 Milestone 1

Comments

@oceanc80
Copy link
Contributor

oceanc80 commented Nov 30, 2022

Move all interfaces and broader implementations of those interfaces from internal to pkg
Only keep internal implementation details of the interfaces in internal

Make Deppy importable

@akihikokuroda
Copy link
Member

How is the solver triggered by keeping the solver package in internal? I think the 'sat' package should be internal but the solver package may need to be exported.

@perdasilva
Copy link
Contributor

Yeah, I agree. It might be hard to keep the sat package internal though. The reason is the constraint interface relies has package internal methods that are required by the solver. Furthermore, those methods make use of package internal structures (e.g. litMapping). For now, I think we should move everything to pkg to make it easy to be imported by other package. Then move things that are internal to the implementation to internal. This may require some refactoring of the sat solver package though.

@perdasilva
Copy link
Contributor

I've put up the PR to move everything to pkg: #79

@akihikokuroda
Copy link
Member

It may be difficult to achieve #50 once we expose the sat package. Are we giving it up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
olm-v1/m1 OLM v1 Milestone 1
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants