-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Deppy to be imported by other packages #73
Comments
How is the solver triggered by keeping the |
Yeah, I agree. It might be hard to keep the sat package internal though. The reason is the constraint interface relies has package internal methods that are required by the solver. Furthermore, those methods make use of package internal structures (e.g. litMapping). For now, I think we should move everything to pkg to make it easy to be imported by other package. Then move things that are internal to the implementation to |
I've put up the PR to move everything to |
It may be difficult to achieve #50 once we expose the sat package. Are we giving it up? |
Move all interfaces and broader implementations of those interfaces from
internal
topkg
Only keep internal implementation details of the interfaces in
internal
Make Deppy importable
internal
The text was updated successfully, but these errors were encountered: