fix: renaming empty sting (#1096)

Author: csviri

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/ReconcilerUtils.java

@@ -75,7 +75,7 @@ public static String getNameFor(Class<? extends Reconciler> reconcilerClass) {
     final var annotation = reconcilerClass.getAnnotation(ControllerConfiguration.class);
     if (annotation != null) {
       final var name = annotation.name();
-      if (!Constants.EMPTY_STRING.equals(name)) {
+      if (!Constants.NO_VALUE_SET.equals(name)) {
         return name;
       }
     }

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/Constants.java

@@ -2,7 +2,7 @@
 
 public final class Constants {
 
-  public static final String EMPTY_STRING = "";
+  public static final String NO_VALUE_SET = "";
   public static final String WATCH_CURRENT_NAMESPACE = "JOSDK_WATCH_CURRENT";
   public static final long NO_RECONCILIATION_MAX_INTERVAL = -1L;
 

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/ControllerConfiguration.java

@@ -12,7 +12,7 @@
 @Target({ElementType.TYPE})
 public @interface ControllerConfiguration {
 
-  String name() default Constants.EMPTY_STRING;
+  String name() default Constants.NO_VALUE_SET;
 
   /**
    * Optional finalizer name, if it is not provided, one will be automatically generated. Note that
@@ -22,7 +22,7 @@
    *
    * @return the finalizer name
    */
-  String finalizerName() default Constants.EMPTY_STRING;
+  String finalizerName() default Constants.NO_VALUE_SET;
 
   /**
    * If true, will dispatch new event to the controller if generation increased since the last
@@ -48,7 +48,7 @@
    *
    * @return the label selector
    */
-  String labelSelector() default Constants.EMPTY_STRING;
+  String labelSelector() default Constants.NO_VALUE_SET;
 
   /**
    * <p>

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/dependent/Dependent.java

@@ -1,11 +1,11 @@
 package io.javaoperatorsdk.operator.api.reconciler.dependent;
 
-import static io.javaoperatorsdk.operator.api.reconciler.Constants.EMPTY_STRING;
+import static io.javaoperatorsdk.operator.api.reconciler.Constants.NO_VALUE_SET;
 
 public @interface Dependent {
 
   @SuppressWarnings("rawtypes")
   Class<? extends DependentResource> type();
 
-  String name() default EMPTY_STRING;
+  String name() default NO_VALUE_SET;
 }

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/KubernetesDependent.java

@@ -5,7 +5,7 @@
 import java.lang.annotation.RetentionPolicy;
 import java.lang.annotation.Target;
 
-import static io.javaoperatorsdk.operator.api.reconciler.Constants.EMPTY_STRING;
+import static io.javaoperatorsdk.operator.api.reconciler.Constants.NO_VALUE_SET;
 
 @Retention(RetentionPolicy.RUNTIME)
 @Target({ElementType.TYPE})
@@ -27,5 +27,5 @@
    *
    * @return the label selector
    */
-  String labelSelector() default EMPTY_STRING;
+  String labelSelector() default NO_VALUE_SET;
 }

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/KubernetesDependentResourceConfig.java

@@ -1,11 +1,11 @@
 package io.javaoperatorsdk.operator.processing.dependent.kubernetes;
 
-import static io.javaoperatorsdk.operator.api.reconciler.Constants.EMPTY_STRING;
+import static io.javaoperatorsdk.operator.api.reconciler.Constants.NO_VALUE_SET;
 
 public class KubernetesDependentResourceConfig {
 
   private String[] namespaces = new String[0];
-  private String labelSelector = EMPTY_STRING;
+  private String labelSelector = NO_VALUE_SET;
 
   public KubernetesDependentResourceConfig() {}
 

operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/event/source/CustomResourceSelectorTest.java

@@ -134,7 +134,7 @@ public TestCustomResource newMyResource(String app, String namespace) {
   public static class MyConfiguration extends DefaultControllerConfiguration<TestCustomResource> {
 
     public MyConfiguration() {
-      super(MyController.class.getCanonicalName(), "mycontroller", null, Constants.EMPTY_STRING,
+      super(MyController.class.getCanonicalName(), "mycontroller", null, Constants.NO_VALUE_SET,
           false, null,
           null, null, null, TestCustomResource.class, null, null);
     }