refactor: remove Cleaner interface

Author: metacosm

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/dependent/Cleaner.java

@@ -11,10 +11,13 @@ default EventSource initEventSource(EventSourceContext<P> context) {
     throw new IllegalStateException("Must be implemented if not automatically provided by the SDK");
   }
 
+  @SuppressWarnings("unchecked")
   default Class<R> resourceType() {
     return (Class<R>) Utils.getFirstTypeArgumentFromInterface(getClass());
   }
 
+  default void delete(R fetched, P primary, Context context) {}
+
   /**
    * todo: return Optional<R></R> instead?
    * 

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/dependent/DependentResource.java

@@ -4,23 +4,19 @@
 import io.javaoperatorsdk.operator.api.config.dependent.DependentResourceConfiguration;
 import io.javaoperatorsdk.operator.api.reconciler.Context;
 import io.javaoperatorsdk.operator.api.reconciler.EventSourceContext;
-import io.javaoperatorsdk.operator.api.reconciler.dependent.Cleaner;
 import io.javaoperatorsdk.operator.api.reconciler.dependent.DependentResource;
 import io.javaoperatorsdk.operator.api.reconciler.dependent.Persister;
 import io.javaoperatorsdk.operator.processing.event.source.EventSource;
 
 public class DependentResourceController<R, P extends HasMetadata, C extends DependentResourceConfiguration<R, P>>
-    implements DependentResource<R, P>, Persister<R, P>, Cleaner<R, P> {
+    implements DependentResource<R, P>, Persister<R, P> {
 
-  private final Cleaner<R, P> cleaner;
   private final Persister<R, P> persister;
   private final DependentResource<R, P> delegate;
   private final C configuration;
-
-  @SuppressWarnings("unchecked")
+  
   public DependentResourceController(DependentResource<R, P> delegate, C configuration) {
     this.delegate = delegate;
-    cleaner = (delegate instanceof Cleaner) ? (Cleaner<R, P>) delegate : null;
     persister = initPersister(delegate);
     this.configuration = configuration;
   }
@@ -40,6 +36,11 @@ public R desired(P primary, Context context) {
     return delegate.desired(primary, context);
   }
 
+  @Override
+  public void delete(R fetched, P primary, Context context) {
+    delegate.delete(fetched, primary, context);
+  }
+
   @SuppressWarnings("unchecked")
   protected Persister<R, P> initPersister(DependentResource<R, P> delegate) {
     if (delegate instanceof Persister) {
@@ -54,11 +55,6 @@ public String descriptionFor(R resource) {
     return resource.toString();
   }
 
-  @Override
-  public void delete(R fetched, P primary, Context context) {
-    cleaner.delete(fetched, primary, context);
-  }
-
   public Class<R> getResourceType() {
     return delegate.resourceType();
   }
@@ -68,10 +64,6 @@ public EventSource initEventSource(EventSourceContext<P> context) {
     return delegate.initEventSource(context);
   }
 
-  public boolean deletable() {
-    return cleaner != null;
-  }
-
   @Override
   public void createOrReplace(R dependentResource, Context context) {
     persister.createOrReplace(dependentResource, context);

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/DependentResourceController.java

@@ -85,9 +85,7 @@ public UpdateControl<R> reconcile(R resource, Context context) {
   public DeleteControl cleanup(R resource, Context context) {
     initContextIfNeeded(resource, context);
 
-    dependents.stream()
-        .filter(DependentResourceController::deletable)
-        .forEach(dependent -> {
+    dependents.forEach(dependent -> {
           var dependentResource = dependent.getFor(resource, context);
           if (dependentResource != null) {
             dependent.delete(dependentResource, resource, context);

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/DependentResourceManager.java

@@ -6,7 +6,6 @@
 
 import io.javaoperatorsdk.operator.api.reconciler.Context;
 import io.javaoperatorsdk.operator.api.reconciler.EventSourceContext;
-import io.javaoperatorsdk.operator.api.reconciler.dependent.Cleaner;
 import io.javaoperatorsdk.operator.api.reconciler.dependent.DependentResource;
 import io.javaoperatorsdk.operator.api.reconciler.dependent.Persister;
 import io.javaoperatorsdk.operator.processing.event.source.EventSource;
@@ -17,8 +16,7 @@
 import static java.lang.String.format;
 
 public class SchemaDependentResource
-    implements DependentResource<Schema, MySQLSchema>, Cleaner<Schema, MySQLSchema>,
-    Persister<Schema, MySQLSchema> {
+    implements DependentResource<Schema, MySQLSchema>, Persister<Schema, MySQLSchema> {
 
   private static final int POLL_PERIOD = 500;
   private MySQLDbConfig dbConfig;