Skip to content

Commit c83e3ed

Browse files
committed
release leader election lease on manager cancellation
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
1 parent 9b08aea commit c83e3ed

File tree

2 files changed

+13
-11
lines changed

2 files changed

+13
-11
lines changed

catalogd/cmd/catalogd/main.go

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -227,12 +227,13 @@ func main() {
227227

228228
// Create manager
229229
mgr, err := ctrl.NewManager(cfg, ctrl.Options{
230-
Scheme: scheme,
231-
Metrics: metricsServerOptions,
232-
PprofBindAddress: pprofAddr,
233-
HealthProbeBindAddress: probeAddr,
234-
LeaderElection: enableLeaderElection,
235-
LeaderElectionID: "catalogd-operator-lock",
230+
Scheme: scheme,
231+
Metrics: metricsServerOptions,
232+
PprofBindAddress: pprofAddr,
233+
HealthProbeBindAddress: probeAddr,
234+
LeaderElection: enableLeaderElection,
235+
LeaderElectionID: "catalogd-operator-lock",
236+
LeaderElectionReleaseOnCancel: true,
236237
// Recommended Leader Election values
237238
// https://github.com/openshift/enhancements/blob/61581dcd985130357d6e4b0e72b87ee35394bf6e/CONVENTIONS.md#handling-kube-apiserver-disruption
238239
LeaseDuration: ptr.To(137 * time.Second),

cmd/operator-controller/main.go

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -228,11 +228,12 @@ func main() {
228228
}
229229

230230
mgr, err := ctrl.NewManager(ctrl.GetConfigOrDie(), ctrl.Options{
231-
Scheme: scheme.Scheme,
232-
Metrics: metricsServerOptions,
233-
HealthProbeBindAddress: probeAddr,
234-
LeaderElection: enableLeaderElection,
235-
LeaderElectionID: "9c4404e7.operatorframework.io",
231+
Scheme: scheme.Scheme,
232+
Metrics: metricsServerOptions,
233+
HealthProbeBindAddress: probeAddr,
234+
LeaderElection: enableLeaderElection,
235+
LeaderElectionID: "9c4404e7.operatorframework.io",
236+
LeaderElectionReleaseOnCancel: true,
236237
// Recommended Leader Election values
237238
// https://github.com/openshift/enhancements/blob/61581dcd985130357d6e4b0e72b87ee35394bf6e/CONVENTIONS.md#handling-kube-apiserver-disruption
238239
LeaseDuration: ptr.To(137 * time.Second),

0 commit comments

Comments
 (0)