Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support kinds: Service, NetworkPolicy in CSV #1858

Closed
saada opened this issue Nov 10, 2020 · 5 comments
Closed

Support kinds: Service, NetworkPolicy in CSV #1858

saada opened this issue Nov 10, 2020 · 5 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/support Indicates an issue that is a support question. triage/unresolved Indicates an issue that can not or will not be resolved.

Comments

@saada
Copy link

saada commented Nov 10, 2020

Feature Request

Is your feature request related to a problem? Please describe.
I have an operator that I would like to add to OperatorHub. OLM CSV allows deployments and RBAC permissions, but no clear way to setup other kinds such as Service and NetworkPolicy. We need these kinds because the operator has multiple CRDs and deployments that talk to each other over the network.

Describe the solution you'd like
Is it possible to add support for other kinds? Maybe add a CSV.spec.services and a CSV.spec.networkpolicies? OR support plain YAML manifests with those resources?

@saada saada changed the title OLM doesn't support kind: Service, NetworkPolicy Support kind: Service, NetworkPolicy in CSV Nov 10, 2020
@saada saada changed the title Support kind: Service, NetworkPolicy in CSV Support kinds: Service, NetworkPolicy in CSV Nov 10, 2020
@exdx
Copy link
Member

exdx commented Nov 11, 2020

Hi @saada,

OLM supports adding services to the operator bundle as plain yaml manifests. OLM will install the service in the same namespace as the operator when installing the bundle. There's no need to reference the service in the CSV explicitly 👍

@exdx exdx added the triage/support Indicates an issue that is a support question. label Nov 12, 2020
@saada
Copy link
Author

saada commented Nov 12, 2020

@exdx , thanks for your response. I'm running into errors when running

operator-sdk bundle validate --select-optional=operatorhub . --verbose

ERRO[0000] Error: Value networking.k8s.io/v1, Kind=NetworkPolicy: unsupported media type registry+v1 for bundle object 

Is there a different media type I should be using?

@exdx
Copy link
Member

exdx commented Nov 12, 2020

@saada so we currently support Service type objects but not NetworkPolicy objects in the bundle.

NetworkPolicy is an interesting resource because even though it's namespace scoped it could potentially affect other workloads in the cluster. We have added support for PodDisruptionBudget and PriorityClass types, which also can affect other workloads, but we were careful to provide additional documentation and validation for these objects. See

So we could potentially add support for NetworkPolicy objects in the bundle but would have to go about it carefully. You could file an RFE at https://issues.redhat.com/projects/RFE/ (public) and we can prioritize it further from there.

@exdx exdx added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 12, 2020
@stale
Copy link

stale bot commented Jan 11, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 11, 2021
@openshift-ci-robot openshift-ci-robot added triage/unresolved Indicates an issue that can not or will not be resolved. and removed wontfix labels Jan 12, 2021
@awgreene
Copy link
Member

awgreene commented Feb 5, 2021

Closing this issue in favor of #1996.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/support Indicates an issue that is a support question. triage/unresolved Indicates an issue that can not or will not be resolved.
Projects
None yet
Development

No branches or pull requests

4 participants