Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do we support multi version of InstallPlan exists? #1871

Closed
hchenxa opened this issue Nov 19, 2020 · 4 comments
Closed

do we support multi version of InstallPlan exists? #1871

hchenxa opened this issue Nov 19, 2020 · 4 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@hchenxa
Copy link

hchenxa commented Nov 19, 2020

Type of question

Are you asking about community best practices, how to implement a specific feature, or about general context and help around the operator-sdk?

Question

What did you do?

I have an operator installed and set the approve method as manually.

Then I have a new version of catalogsource image updated, it will trigged to create an installPlan with the new changes in.
But I found the the catalogsource image was not valid, and then I fix the problem and have an other version of catalogsource image updated, But it will not create a new InstallPlan with the new changes in since the old of installPlan was still exists.

So 1), Do I need to delete the old installPlan before apply the new catalogsource image? 2), why there can not have multi installPlan preexists and let approval to select which version should be approved?

What did you expect to see?

I just want to have a latest version of my operators bumped with the new change and have a installPlan to apply the changes to my operators.

What did you see instead? Under which circumstances?
A clear and concise description of what you expected to happen (or insert a code snippet).

see above.

Environment

  • operator-lifecycle-manager version:
    ocp 4.6.1
  • Kubernetes version information:
  • Kubernetes cluster kind:

Additional context
Add any other context about the question here.

@hchenxa
Copy link
Author

hchenxa commented Nov 25, 2020

@dinhxuanvu @tlwu2013 any comments here?

@dinhxuanvu
Copy link
Member

Hey @hchenxa, at the moment, multiple versions of pending InstallPlans are not supported. Every time OLM resolves an operator installation/upgrade, it will have to take into account all of dependencies/requirements from other operators in the same namespace, the final resolution is one and only solution at that time which leads to a single InstallPlan that you see. You either accept that solution or decline it given if OLM to resolve happen again, the resolution may be different.
However, having said that, there is a recent change that allows OLM to re-resolve the operator again if you delete the pending InstallPlan (in Manual Approve mode). So if you don't like the current resolution, delete the pending InstallPlan and OLM will resolve again with the new information (if there is). Here is the original PR.
Please keep in mind, OLM will follow the strict upgrade path that has been established in CatalogSource. So you may not be able to randomly skip to the version that you desire without it being allowable in the upgrade graph.

@stale
Copy link

stale bot commented Feb 28, 2021

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contribution.
For more help on your issue, check out the olm-dev channel on the kubernetes slack [1] and the OLM Dev Working Group [2] [1] https://kubernetes.slack.com/archives/C0181L6JYQ2 [2] https://github.com/operator-framework/community#operator-lifecycle-manager-wg

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 28, 2021
@stale
Copy link

stale bot commented Mar 8, 2021

This issue has been automatically closed because it has not had any recent activity. Thank you for your contribution.

@stale stale bot closed this as completed Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

2 participants