Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Webhook to control overrides of OperatorCondition #1889

Closed
dinhxuanvu opened this issue Dec 4, 2020 · 2 comments
Closed

Use Webhook to control overrides of OperatorCondition #1889

dinhxuanvu opened this issue Dec 4, 2020 · 2 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@dinhxuanvu
Copy link
Member

dinhxuanvu commented Dec 4, 2020

Feature Request

Is your feature request related to a problem? Please describe.
I think a better UX would be to have spec.overrides actually change the value of status to match the overridden value, and then reject any external changes to status while the override is set (this is the part that requires a webhook).

Otherwise anyone else that is not OLM (including e.g. the UI) needs to re-implement this union logic. And the problem will grow as more supported conditions are added.

Describe the solution you'd like
Using a Webhook to match the overrides.Conditions to match status.Conditions and enforce the overridden values until they are cleared.

@dinhxuanvu dinhxuanvu added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 4, 2020
@stale
Copy link

stale bot commented Mar 4, 2021

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contribution.
For more help on your issue, check out the olm-dev channel on the kubernetes slack [1] and the OLM Dev Working Group [2] [1] https://kubernetes.slack.com/archives/C0181L6JYQ2 [2] https://github.com/operator-framework/community#operator-lifecycle-manager-wg

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 4, 2021
@stale
Copy link

stale bot commented Mar 12, 2021

This issue has been automatically closed because it has not had any recent activity. Thank you for your contribution.

@stale stale bot closed this as completed Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

1 participant