Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golangci-lint check fails #2723

Closed
georgettica opened this issue Apr 4, 2022 · 1 comment
Closed

golangci-lint check fails #2723

georgettica opened this issue Apr 4, 2022 · 1 comment
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@georgettica
Copy link

georgettica commented Apr 4, 2022

Bug Report

What did you do?

Use the latest version of olm in a fork

What did you expect to see?
A clear and concise description of what you expected to happen (or insert a code snippet).

that the github actions (GHA) will pass

What did you see instead? Under which circumstances?
A clear and concise description of what you expected to happen (or insert a code snippet).

the GHA fork action failed on linting

Environment

  • operator-lifecycle-manager version:

N/A

  • Kubernetes version information:

N/A

  • Kubernetes cluster kind:

N/A

Possible Solution
to set the golangci-lint version to go1.17
as of now there is a list linters that work with 1.18 but not all of them.

Additional context
see this page for the status of the golangci-lint state

@georgettica georgettica added the kind/bug Categorizes issue or PR as related to a bug. label Apr 4, 2022
@timflannagan
Copy link
Contributor

Thanks for the report - it looks like I forgot to link up this issue with the #2724 PR that bumps the golangci-lint action to a version that plays well with Go 1.17, so automation didn't automatically close this. The https://github.com/operator-framework/operator-lifecycle-manager/runs/5820704445?check_suite_focus=true action just passed (which ran against the master branch) so I'm going to close this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

2 participants