Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/metrics: Return Service so user can make changes #1107

Closed
lilic opened this issue Feb 18, 2019 · 2 comments
Closed

pkg/metrics: Return Service so user can make changes #1107

lilic opened this issue Feb 18, 2019 · 2 comments
Assignees

Comments

@lilic
Copy link
Member

lilic commented Feb 18, 2019

As per @joelanford suggestion -> #1037 (comment), there are times a user might want to make changes to the Service object before its being created, we should consider returning the object first before creating it, and do the creation in the main.go file instead of the operator-sdk metrics package.

Discussion is needed for this, as it breaks the API.

@lilic
Copy link
Member Author

lilic commented Jun 5, 2019

As part of this we also want to:

  • change the name of the Service to append the -metrics string to it, so it's self descriptive
  • pass port and name to be able to add more /metrics endpoints.

@lilic
Copy link
Member Author

lilic commented Jul 2, 2019

  • change the name of the Service to append the -metrics string to it, so it's self descriptive
  • pass port and name to be able to add more /metrics endpoints.

These two are done.

As decided after some discussion, we do not want to create the Service in the user code, so closing this one. If users want we can expose one of the other helper functions.

@lilic lilic closed this as completed Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants