Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plans to support admission controllers? #269

Closed
n3wscott opened this issue May 21, 2018 · 4 comments
Closed

Any plans to support admission controllers? #269

n3wscott opened this issue May 21, 2018 · 4 comments
Assignees

Comments

@n3wscott
Copy link

Context https://kubernetes.io/docs/admin/admission-controllers/

It would be neat to allow a handler the ability to add webhooks to validate and mutate the CR if required, see https://github.com/kubernetes/kubernetes/blob/01c74145c7b655525fcfcd00720b918d926aa298/pkg/apis/admission/types.go#L79

@spahl
Copy link
Contributor

spahl commented Jun 5, 2018

Assigned to Haseeb to take a look.

@anandsinghkunwar
Copy link

anandsinghkunwar commented Jan 11, 2019

Isn't it possible to just use the controller-runtime webhooks as is? I am not sure on how it is an operator-sdk feature 😕

@hasbro17
Copy link
Contributor

Since this is already supported via the controller-runtime APIs I would defer to that for now.
https://godoc.org/github.com/kubernetes-sigs/controller-runtime/pkg#hdr-Webhook
https://github.com/kubernetes-sigs/controller-runtime/tree/master/example

We could possibly add some scaffolding and docs to show how to use the webhook server APIs.

@hasbro17
Copy link
Contributor

Closing this in favor of #1217 and #1218
We'll track the feature requests for adding scaffolding/docs for validating and mutating admission webhooks over there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants