-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unpin cryptography
Python dep for Ansible Operators
#5739
Comments
cryptogrophy
Python dep for Ansible Operatorscryptography
Python dep for Ansible Operators
This should be pretty easy if anyone wants to pick it up, I'd be willing to coach. |
/assign |
Hi @rudradevpal thank you for picking this up! For this one, you can start by updating the pipfile and then using pipenv to update the .lock file. (Let me know if you need some docs links to figure that out.) From there, you can use Line 84 in 9762aa2
Try out the new image with any ansible-based operator (Memcached tutorial is fine) to make sure it all works. Repeat for Ansible 2.11 preview image. Let me know if you could use any assistance! |
@asmacdo can you please share docs for
do i just remove the |
@asmacdo Can you please help on this issue. Waiting for your reply |
Let's unpin for now. Use pipenv to install dependencies (from the pipfile) into a temp virtualenv, and it should update the lock file. |
So i am just going with putting cryptography= "*" as of now. |
For building and testing, take a look at the makefile. Once the images are building, you should be ok to push a PR and let CI run. |
Okay thanks @asmacdo |
@rudradevpal Would you like still pick up this issue. If not feel free to unassigned yourself. |
We've got this version pinned
https://github.com/operator-framework/operator-sdk/blob/master/images/ansible-operator/Pipfile#L13-L16
It looks like the rust toolkit is available for UBI 8 now, so I think we can start bumping this dep.
Might affect #5619
The text was updated successfully, but these errors were encountered: