Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend sdk to support additional operations #597

Closed
cmoulliard opened this issue Oct 11, 2018 · 1 comment
Closed

Extend sdk to support additional operations #597

cmoulliard opened this issue Oct 11, 2018 · 1 comment

Comments

@cmoulliard
Copy link

Is it possible to extend operator-sdk/pkg/sdk in order to support by example such additional request able to create a subresource for a DeploymentConfig ?

https://goo.gl/uCxqWY

// Instantiate takes the representation of a deploymentRequest and creates it.  Returns the server's representation of the deploymentConfig, and an error, if there is any.
func (c *deploymentConfigs) Instantiate(deploymentConfigName string, deploymentRequest *v1.DeploymentRequest) (result *v1.DeploymentConfig, err error) {
	result = &v1.DeploymentConfig{}
	err = c.client.Post().
		Namespace(c.ns).
		Resource("deploymentconfigs").
		Name(deploymentConfigName).
		SubResource("instantiate").
		Body(deploymentRequest).
		Do().
		Into(result)
	return
}
@shawn-hurley
Copy link
Member

We are moving closer to using the controller runtime and we will be using their client. You can find the documentation here https://godoc.org/sigs.k8s.io/controller-runtime/pkg/client#Client.

It appears that they also do not have support for subresources besides /status.

I am going to close this issue in favor of kubernetes-sigs/controller-runtime#172. We can re-open this feature request depending on the outcome of that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants